Update FunctionComment sniff with phpcs 2 fixes

joomla / coding-standards

Joomla Coding Standards Definition

https://developer.joomla.org/coding-standards/basic-guidelines.html

GNU General Public License v2.0

128 stars 129 forks source link

Update FunctionComment sniff with phpcs 2 fixes #159

Closed photodude closed 7 years ago

photodude commented 7 years ago

FunctionComment sniffs now support variadic functions
- Fix from https://github.com/squizlabs/PHP_CodeSniffer/commit/4966b545db497e038b3ba01fd21c0899be9365a9#diff-e366d95cd64d7200d6b59eca1b5e3093
- Fix for https://github.com/squizlabs/PHP_CodeSniffer/issues/841
FunctionComment sniffs now throw errors for some invalid @param lines

photodude commented 7 years ago

holding off on the changes related to correctly handle multi-line param comments https://github.com/squizlabs/PHP_CodeSniffer/commit/7e92909a0e3e43cbda69a6b0f76c02c597a9f696 as they might not apply to our sniff due to our changes

wilsonge commented 7 years ago

So is this ok to merge then?

photodude commented 7 years ago

I think this can be merged. Do you want to review the referenced phpcs change? I think it doesn't apply but I'm not 100% sure.

photodude commented 7 years ago

I've partially added the changes from squizlabs/PHP_CodeSniffer@7e92909 but due to our Joomla specific changes in the sniff I can't see how the rest of the changes would apply.