search

joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

.md to .html #197

Closed Paladin closed 7 years ago

Paladin commented 7 years ago

fixes the website, breaks the link in GitHub. Your call for which one you want to have broken.

photodude commented 7 years ago

From the manual website https://developer.joomla.org/coding-standards.html I click on the link in the text that is modified in this PR I get the following url with a 404 https://developer.joomla.org/appendices/analysis.md

But if I click on the left-hand menu I get a valid URL https://developer.joomla.org/coding-standards/analysis.html although I question why it dropped the /appendices/ level

the github links are correct

I think this is an issue with the parser that creates the page. @mbabker thoughts?

mbabker commented 7 years ago

One of these days I'm going to have to get a subscription plan for JMarkdown, get the site updated to the current version of the component, and see if there's a way to hook it and process the file somehow to fix the links.

photodude commented 7 years ago

I propose closing this PR and opening an issue indicating the broken link and the cause related to old version of JMarkdown and subsequent parsing.

mbabker commented 7 years ago

I thought we had an issue open somewhere, but looking in https://github.com/joomla/joomla-websites/issues and https://github.com/joomla/developer.joomla.org/issues I guess not.

Paladin commented 7 years ago

Fine by me. Like I said, it's your call. I just promised to submit the PR, didn't promise to insist it get accepted.