joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

[WIP] Update ruleset to represent current CMS state #214

Closed photodude closed 5 years ago

photodude commented 6 years ago

This WIP updates the CMS example Ruleset to be reflective of the current CMS code style state.

There are some very broad exceptions here, but we should be able to clean this up reasonably fast as many of these exceptions apply to sniffs with autofixers.

Open PR's on the CMS should be checked for [CS] fixes in relation to clean up of exceptions

wilsonge commented 5 years ago

I know this is marked as WIP but we need to start building off on this so merging and we can amend as we go

photodude commented 5 years ago

@wilsonge also note that @mbabker created a repository specific to maintaining just a CMS ruleset for the coding standard. see https://github.com/joomla/cms-coding-standards That repo should be just the things the CMS needs. It's just the XML for PHPCS and is for Selectively Applying Rules from this repo's standard. (basically applies all of the CMS specific exclusions)

Ideally, that repo should be able to be installed with this coding standard via composer.

wilsonge commented 5 years ago

Missed that repo. Thanks for pointing it out!

photodude commented 5 years ago

You are welcome @wilsonge