search

joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

Workaround for vscode ikappas.phpcs on PHPCS 2.9.1 #217

Closed anibalsanchez closed 6 years ago

anibalsanchez commented 6 years ago

PHPCS generates a progress output along the errors report.

This modification forces the quiet mode and avoids error: "phpcs: Unexpected token F in JSON at position 0".

This issue is specific of vscode. So, I'm not sure if it's OK to accept this PR in general, just in case I'm sending the PR.

mbabker commented 6 years ago

Personally I'm 👎 as you can just pass the argument when running on the command line (or configure your tool to do so, I don't know about vscode but PhpStorm lets you configure CLI tools), I don't think we need to default the ruleset to run on quiet mode.

anibalsanchez commented 6 years ago

Ok ok, cool. Closing it now.

If someone finds the same issue, the PR will be here for reference.