Errors on try/catch/finally

joomla / coding-standards

Joomla Coding Standards Definition

https://developer.joomla.org/coding-standards/basic-guidelines.html

GNU General Public License v2.0

128 stars 129 forks source link

Errors on try/catch/finally #222

Closed mbabker closed 6 years ago

mbabker commented 6 years ago

Build: https://travis-ci.org/joomla-framework/console/jobs/331583389 Analyzed code: https://github.com/joomla-framework/console/blob/13a8498930831b88c5ece0327a1c46e331a54fb8/src/Application.php#L390-L466

photodude commented 6 years ago

This is a case to report to PHPCS as this is a failure in the sniff Squiz.WhiteSpace.ControlStructureSpacing.NoLineAfterClose

photodude commented 6 years ago

This has been addressed by PHPCS, but the fix might only be put in the 3.2.x master branch https://github.com/squizlabs/PHP_CodeSniffer/issues/1890

We are quickly reaching a point where we need to finalize the PHPCS 2.x branch and move on to the PHPCS3.x branch as the PHPCS 2.9.x branch will somewhat shortly end bug fixes.

photodude commented 6 years ago

I've done the PR for the backport fix on this.

The next release of PHPCS 2.9.x will be the last bug fix for that branch.

We can close this issue here.