search

joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

[4.0] Anonymous class support #231

Closed laoneo closed 5 years ago

laoneo commented 6 years ago

In J4 the extension service providers are written as anonymous classes like here https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/services/provider.php#L25

Currently CS fails on that with the following error:

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)

25 | ERROR | Missing class doc comment

But there is a class do block.

photodude commented 6 years ago

Should work with the 2.x and 3.x versions of the coding standard. With one current issue I have not been able to solve yet. See Issue #230 which shows the test case I found where the current fix from #218 didn't cover all cases.

laoneo commented 6 years ago

When are these standards used in drone for Joomla 4?

photodude commented 6 years ago

@laoneo the 3.x version is not yet used for testing J4. There are a few things needing to be cleaned up for getting the new versions in place. Read the last few comments in #143 for current progress

laoneo commented 6 years ago

Thanks. Should I close this issue?

wilsonge commented 5 years ago

Closing in favour of PR in #242