search

joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

Object Calisthenics - best practise #236

Closed alikon closed 6 years ago

alikon commented 6 years ago

as per discussion on https://github.com/joomla/joomla-cms/pull/20417#issuecomment-390393952

PhilETaylor commented 6 years ago

And who is going to apply these new nine things to the existing code???

No point in new standards when 90% (made up number) of the existing code would then be non compliant!

brianteeman commented 6 years ago

always lookingg to find faults :(

PhilETaylor commented 6 years ago

Copy and pasting random opinions (these being Jeffs opinions) is not the way to design best practice for a mass marked code base

alikon commented 6 years ago

thank you for your words, these words really encourage

PhilETaylor commented 6 years ago

I think it’s absurd that a self described non coder believes he has the mandate to dictate code standards - and also to repeatedly abuse contributors

The 9 rules are just opinion. There are equally others that disagree with these coding opinions. There always will be. But as a project a discussion should be had and a standard adopted. Not just approved in seconds by a non coder.

If only had a community policy with teeth - there would be plenty of evidence to banish Teeman for good. The personal attacks are relentless and well documented.

—— Sent from my iPhone - sorry - if needed I’ll send longer email from my desk later. ——

On 19 May 2018, at 11:46, Nicola Galgano notifications@github.com wrote:

thank you for your words, these words really encourage

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

alikon commented 6 years ago

nemesis

brianteeman commented 6 years ago

If people like you who can develop code actually did instead of constantly blaming those that try then joomla would be in a much better place.

On Sat, 19 May 2018, 13:03 Nicola Galgano, notifications@github.com wrote:

Closed #236 https://github.com/joomla/coding-standards/pull/236.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/joomla/coding-standards/pull/236#event-1635510585, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPH8eDEITi5yt9e2_p6H2hIm3FNrx5jks5tz_vkgaJpZM4UFqHf .

PhilETaylor commented 6 years ago

Brian you are toxic. Period

Fact - I ASKED FOR THIS PR. fact this PR CAME FROM A PR OF MY CODE!

Therefore your argument is invalid. As always.

Once again I’m blocking you. Life is too short to put up with personal attacks.

—— Sent from my iPhone - sorry - if needed I’ll send longer email from my desk later. ——

On 19 May 2018, at 12:25, Brian Teeman notifications@github.com wrote:

If people like you who can develop code actually did instead of constantly blaming those that try then joomla would be in a much better place.

On Sat, 19 May 2018, 13:03 Nicola Galgano, notifications@github.com wrote:

Closed #236 https://github.com/joomla/coding-standards/pull/236.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/joomla/coding-standards/pull/236#event-1635510585, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPH8eDEITi5yt9e2_p6H2hIm3FNrx5jks5tz_vkgaJpZM4UFqHf .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

PhilETaylor commented 6 years ago

In fact Teeman is PERSONALLY RESPONSIBLE for loss of people like me contributing less.

—— Sent from my iPhone - sorry - if needed I’ll send longer email from my desk later. ——

On 19 May 2018, at 12:25, Brian Teeman notifications@github.com wrote:

If people like you who can develop code actually did instead of constantly blaming those that try then joomla would be in a much better place.

On Sat, 19 May 2018, 13:03 Nicola Galgano, notifications@github.com wrote:

Closed #236 https://github.com/joomla/coding-standards/pull/236.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/joomla/coding-standards/pull/236#event-1635510585, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPH8eDEITi5yt9e2_p6H2hIm3FNrx5jks5tz_vkgaJpZM4UFqHf .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

alikon commented 6 years ago

reopened, just the time to dress an anti-gas mask

mbabker commented 6 years ago

Object Calisthenics is heavily opinionated and unenforceable in the Joomla code without extremely disruptive B/C breaks. So no, this can't just be blindly copy/pasted in and enforced as part of the coding standard.