joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

Add codestyle for language files #241

Closed roland-d closed 5 years ago

roland-d commented 5 years ago

As per the discussion in the CMS Maintainers chat, here is a first draft of the codestyle for our language files.

It would be good to have separate section here for INI files but I don't see how I can do that: image

Pinging @infograf768 as the text is his :)

infograf768 commented 5 years ago

We can also add Netbeans plugin: http://plugins.netbeans.org/plugin/45925/sort-line-tools

mbabker commented 5 years ago

It would be good to have separate section here for INI files but I don't see how I can do that:

The documents have to be added in the component backend. Nothing you can do through GitHub.

wilsonge commented 5 years ago

Can we add a note referring to the English style guide please and document that language strings are in en-GB as we're doing this please

infograf768 commented 5 years ago

@roland-d Can you do what George asks?

roland-d commented 5 years ago

@wilsonge Done, can you check if it is OK like this?

wilsonge commented 5 years ago

Sorry just got back from holiday. Looks good to me. Thanks

infograf768 commented 5 years ago

Thanks for merging Now needs to be ported to https://developer.joomla.org/coding-standards/basic-guidelines.html for manual/basic-guidelines.md and to a specific section in https://developer.joomla.org/coding-standards/introduction.html for manual/ini.md

mbabker commented 5 years ago

The pages read from this repo as the site's cache expires, so all content work can happen in this repo and it should sync within the hour.

On the site itself, the only work required is adding the new page to the menu system (because we do still have to tell the component what files from a repo are available as pages, otherwise in the case of this repo we end up in allowing the PHP files to be web pages and we don't want that). And that is done, https://developer.joomla.org/coding-standards/ini.html

roland-d commented 5 years ago

Thanks @mbabker

infograf768 commented 5 years ago

👍

rvbgnu commented 5 years ago

Thanks @roland-d @wilsonge @mbabker @infograf768 ! Good things to have it here.