search

joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

Allow short array syntax #248

Closed Hackwar closed 5 years ago

Hackwar commented 5 years ago

What the title says. I see no reason to prevent that.

HLeithner commented 5 years ago

I think master is Joomla 3 with php 5.3 support and dev-3.0 branch is J4 which has this already removed.

mbabker commented 5 years ago

^^ That. 2.0 coding standard (which corresponds with PHPCS 2.x) is PHP 5.3 friendly and by default disallows short array syntax, the 3.0 coding standard (which corresponds with PHPCS 3.x) doesn't support PHP 5.3 so short array syntax is allowed by default.

Branching's a little wrong here, realistically master should be 3.x and 2.0 should be a branch but ¯\_(ツ)_/¯

Hackwar commented 5 years ago

Ok, closing this one, but then we should fix that thing with the branches...