Don't allow package tags in namespaced files

joomla / coding-standards

Joomla Coding Standards Definition

https://developer.joomla.org/coding-standards/basic-guidelines.html

GNU General Public License v2.0

128 stars 129 forks source link

Don't allow package tags in namespaced files #255

Closed SharkyKZ closed 4 years ago

SharkyKZ commented 4 years ago

Pull request for https://github.com/joomla/joomla-cms/issues/26395.

@mbabker please review. Should this be applied to all namespaced files or only to namespaced classes? We don't have the former in the CMS so not sure how to handle those.

wilsonge commented 4 years ago

I'd stick with namespaced classes.

SharkyKZ commented 4 years ago

I somehow totally screwed up this code, nothing makes sense 🤦‍♂

SharkyKZ commented 4 years ago

Should be good now.

wilsonge commented 4 years ago

Let's give it a spin :)

SharkyKZ commented 4 years ago

Thanks.