search

joomla / coding-standards

Joomla Coding Standards Definition
https://developer.joomla.org/coding-standards/basic-guidelines.html
GNU General Public License v2.0
128 stars 129 forks source link

Updates to IDE xml's - Version note them? #48

Open Hutchy68 opened 10 years ago

Hutchy68 commented 10 years ago

Do we need to version out the IDE xml's? Or are we assuming every dev will have the latest version of their IDE of choice?

@betweenbrain you have https://github.com/betweenbrain/phpstorm-joomla-code-style/blob/master/Joomla.xml which works with the latest phpstorm? Or a specific version? For what version did @elkuku push.

There is also a PR version for fixes to Eclipse Kepler, assuming the current one for Eclipse is for Indigo. Current xml file is 2 years old.

elkuku commented 10 years ago

I would assume that every dev is using the latest and greatest version of his/her IDE, so the XML files we are keeping here should be compatible with this version. I wouldn't put a specific version, but maybe something like "Tested with [IDE_NAME] version [VERSION_NO]" in the general readme, and maybe a link to a reference page (I just did that for PHPStorm here => #49)

I am afraid I can not remember which version of PHPStorm I was running when I submitted the XML file here, I guess it was about 3. I am currently running 7.1 and it still works ;) The file @betweenbrain has in his repo however looks much more "complete", containing also formatting rules for CSS and JavaScript - would be nice merging those ;)

betweenbrain commented 10 years ago

@elkuku thanks. I'd be happy to see them merged.

@hutchey68 that file should work with PhpStorm versions 5+, maybe earlier. I am currently using it with the latest version and all seems well. I do need to update o e small bit, but it should be fairly comprehensive.

I also don't think that we need to version them as they mostly tend to be backward compatible.

Hutchy68 commented 10 years ago

Thanks guys, references to what works should be ok as a indicator. I think most update their IDE as they become available too.