search

joomla / framework.joomla.org

Application powering the internet home of the Joomla! Framework
https://framework.joomla.org
GNU General Public License v2.0
37 stars 28 forks source link

add LICENSE in README #50

Closed Parikshit-Hooda closed 2 years ago

Parikshit-Hooda commented 4 years ago

Add license section to the README

Parikshit-Hooda commented 4 years ago

would love to take up this issue as part of hacktoberfest!

mbabker commented 4 years ago

Feel free to submit a pull request if you're so inclined.

My two cents though is I don't think the license is needed in the README for application repos (like this one, or https://github.com/joomla/statistics-server, or https://github.com/joomla/help.joomla.org) because they aren't intended to be general purpose re-usable applications and the README content is moreso tailored toward getting the application up and running. The apps are all licensed appropriately with a LICENSE file at the root so the info is there, but this type of repo is a case where it doesn't need to be as prominent.

For repos with reusable code (like the main CMS repo, or extensions in https://github.com/joomla-extensions, or packages in https://github.com/joomla-framework) then it makes sense to have the license right in the README and is a convention followed by a lot of repos.

Hackwar commented 2 years ago

The repo is marked as GPL and @mbabker correctly wrote that we don't need this. Closing this issue.