joomla / install-from-web-server

Repository holding the component powering the Install from Web server.
9 stars 31 forks source link

Replaces legacy JED url with the CDN url for images #26

Closed andergmartins closed 9 years ago

andergmartins commented 9 years ago

Related to #7

beat commented 9 years ago

From code-reivew pov, i'm giving a :+1: Waiting for a successful tester before merge and upload to staging (and then hopefully to live quickly) Thanks a lot for your contribution!

andergmartins commented 9 years ago

Instructions for testers:

What to test

The domain used on the URL for images in the "Install From Web" tab. Originally it was "http://extensions.joomla.org/" and now it is replaced by the content of the "CDN Prefix" param from com_app. The correct URL should be "https://extensionscdn.joomla.org/".

How to test

Preparing

  1. Make sure you have this repo cloned, updated,installed and running locally;
  2. Go to any other local Joomla site you have and manually update the file "/plugins/installer/webinstaller/webinstaller.php" changing the default value of the attribute $appsBaseUrl (line 21) pointing to your local installation of this repo, like:

... public $appsBaseUrl = 'http://localhost/installfromweb/'; ...

  1. Load the admin site found on this repo and load the System Global Configuration > com_app;
  2. Set the param "CDN Prefix" to "https://extensionscdn.joomla.org/" ("URL & CDN Settings" tab) and save;

Testing

  1. Load the other local Joomla site;
  2. Go to the Extensions Manager > Install from Web tab. You should see the grid/list of extensions instead of the warning about JED disabled.
  3. Use the browser DOM inspector to select an image from any extension and check if the domain is pointing to the new CDN url you set on the step 4 while preparing.
peterlose commented 9 years ago

Tested. All good!

skaermbillede 2015-04-22 kl 14 55 36

andergmartins commented 9 years ago

Nice!, thanks @losedk

beat commented 9 years ago

Thanks @andergmartins for the MR and @losedk for the tests! Merging!

andergmartins commented 9 years ago

Nice, thanks. You're welcome!