search

joomla / install-from-web-server

Repository holding the component powering the Install from Web server.
9 stars 31 forks source link

Get resizeDown image from JED #29

Closed nicksavov closed 9 years ago

nicksavov commented 9 years ago

Potential fix for https://github.com/joomla-extensions/install-from-web-server/issues/27 . This one uses regex.

andergmartins commented 9 years ago

Code reviewed, looks good! :)

peterlose commented 9 years ago

Tested. Works fine.

peterlose commented 9 years ago

Should we get this merged, so it could be activated again? :)

beat commented 9 years ago

With the successful tests, I will now merge this PR.

But I would like to insist that this is a temporary workaround until JED API is able to return us downsampled cached images urls at the right size that we need as part of the JSON record.

E.g. Our JSON request could contain image_size_x and image_size_y parameters and the JSON reply return corresponding sized image-URL. That way, category-lists and individual entries would each have their own right-sized images.

beat commented 9 years ago

Also uploaded to staging now for final tests before going live!

peterlose commented 9 years ago

@beat Great. Perhaps we should create an issue so it's not forgotten?

peterlose commented 9 years ago

ahh there's one already :)

nicksavov commented 9 years ago

Thanks guys!

beat commented 9 years ago

@losedk do you have the URL to the JED API resized-image-sizes needed params / issue ?