joomla / install-from-web-server

Repository holding the component powering the Install from Web server.

9 stars 31 forks source link

Convert all JED ext images to resizeDown version #30

Closed nicksavov closed 9 years ago

nicksavov commented 9 years ago

I missed some logos with the /images/ path. This PR caches both variants.

e.g. http://extensionscdn.joomla.org/cache/fab_image/images/53140.png should become: http://extensionscdn.joomla.org/cache/fab_image/53140_resizeDown302px133px16.png

and: http://extensionscdn.joomla.org/cache/fab_image/logo/548ff93e7bdd0.png should become: http://extensionscdn.joomla.org/cache/fab_image/548ff93e7bdd0_resizeDown302px133px16.png

coolbung commented 9 years ago

test works correctly for me !

Tested for the Phoca Gallery image that loads up on the dashboard

beat commented 9 years ago

@nicksavov thanks for the fix! @coolbung thanks for the test! merging!

beat commented 9 years ago

Staging updated :+1:

beat commented 9 years ago

Home Page size is better: instead of 50 MB, it is now 10 MB.

To bring it further down to an acceptable size (< 1-2MB), we probably need smaller right-sized thumbs from JED API, or/and lazy image loading client-side. I guess it's not a show-stopper.