search

joomla / install-from-web-server

Repository holding the component powering the Install from Web server.
9 stars 31 forks source link

Updates to list view #40

Closed C-Lodder closed 6 years ago

C-Lodder commented 6 years ago

Wrap the entire list item in an <a>

brianteeman commented 6 years ago

this is not correct as it kills the link to the reviews

mbabker commented 6 years ago

Right.

The current setup is pretty similar, only the title/description text links to the item page (it just has some CSS rules to make it look like a link). So we do need to either keep it JavaScript-ish or come up with a solution that doesn't kill the reviews link.

brianteeman commented 6 years ago

actually i had to add the css here https://github.com/joomla/joomla-cms/pull/19421

C-Lodder commented 6 years ago

@brianteeman There is a link to the reviews page on the 2nd page, once you've clicked an item. I don't see the need for it on the list view

brianteeman commented 6 years ago

This is not the time to change the functionality

mbabker commented 6 years ago

For now the aim is to have feature/UI parity with the existing 3.x stuff. We can get into other changes later (that should be made to both versions of the markup), let's try to keep the behavior consistent regardless of major Joomla version in use.

brianteeman commented 6 years ago

and consistent across the views ;)

C-Lodder commented 6 years ago

Sure no problem then. If that's the agreed scope for now, I'm cool with that.