search

joomla / install-from-web-server

Repository holding the component powering the Install from Web server.
9 stars 31 forks source link

add noopener noreferrer to developer website link #50

Closed alikon closed 4 years ago

alikon commented 4 years ago

As reported https://github.com/joomla/joomla-cms/issues/28978 added the rel="noopener noreferrer" to developer website link

brianteeman commented 4 years ago

Shouldn't the other external links also be updated

alikon commented 4 years ago

the original issue was only about the developer link.... but if we can have a consensus.... why not ....

brianteeman commented 4 years ago

All the external links should have noreferrer etc They do in joomla itself so they should do here. In fact its even more important here

alikon commented 4 years ago

silly question even all the JED links should be considered as external link ?

i mean all the <a target="_blank" links on https://github.com/joomla/install-from-web-server/blob/master/components/com_apps/layouts/apps/j4/extensions_full.php and on https://github.com/joomla/install-from-web-server/blob/master/components/com_apps/layouts/apps/j3/extensions_full.php

alikon commented 4 years ago

the change will be really cheap, but i'm a bit scared about different opinions

conconnl commented 4 years ago

@JazParkyn can you share the opinion from JED point of view? Do you agree with @alikon ? I do as links go to another site and not the one you are working on.

JazParkyn commented 4 years ago

I don’t think there’s any question here, all external links should have rel="noopener noreferrer"

alikon commented 4 years ago

fair enough for me, please double check if i've missed some urls