joomla / jissues

Issue tracking application extending GitHub's issues and pull requests for the Joomla! project.
https://issues.joomla.org
GNU General Public License v2.0
71 stars 82 forks source link

J!5 CodeMirror: F10 to toggle Full Screen editing. #1221

Closed pedro-olaia closed 7 months ago

pedro-olaia commented 7 months ago

If you are submitting an issue for the Joomla! CMS, please submit it at https://github.com/joomla/joomla-cms/issues/new instead. You may remove this line from the issue template.

Steps to reproduce the issue

Set default editor as CodeMirror then create or opem any element like an article, category or module in joomla administration area where the editor can be used, click inside the editor area and then press F10 to toogle full screen editing.

Expected result

The editor expands to occupy a big area of the browser window, overlapping and hidding the interface elements underneath the editor.

Actual result

The editor expands to occupy a big area of the browser window, but the Codemirror background is transparent and you can see all other elements underneath the editor making content editing very confusing.

System information (as much as possible)

Joomla! Version: Joomla! 5.0.2 Stable [ Kuboresha ] 9-January-2024 16:00 GMT PHP Version: 8.1.10 Database Type: mysql Database Collation: utf8mb4_general_ci

Additional comments

Also the tab key makes the cursor jump from the editing area to the next button out of the editor. Making it impossible to indent content with the Tab key.

pedro-olaia commented 7 months ago

Solved on: https://github.com/joomla/joomla-cms/pull/42683#issue-2092492510