joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.76k stars 3.64k forks source link

com_fields editor field, editor plugin wierdness #14935

Closed PhilETaylor closed 7 years ago

PhilETaylor commented 7 years ago

Steps to reproduce the issue

Install from joomla-cms/staging Due to bugs in the HEAD Im using commit 1f89fb09d941d3c7d14b366ffe84d880f9347cf7 for this test

Add an editor custom field in com_fields

Edit a content item, click fields tab, see the new editor, then attempt to use an editor plugin from the bottom row

screen shot 2017-03-27 at 16 24 40

Expected result

The features work as expected, and insert their results into the Editor Custom Field area

Actual result

The features popup into a modal, and on selecting their item, the modal stays shown and the results are inserted into the editor on the Content Tab and NOT into the new editor on the field tab.

System information (as much as possible)

https://gist.github.com/PhilETaylor/9d3c6591ed3d7d5273626f8c5d7ae193

Additional comments

Tested on FRONT and BACK end

PhilETaylor commented 7 years ago

hmmm @mbabker what was that issue with the Patch tester where it doesnt apply patches right?

PhilETaylor commented 7 years ago
    modified:   administrator/components/com_content/models/forms/article.xml
    modified:   media/editors/tinymce/js/tinymce.js
    modified:   media/editors/tinymce/js/tinymce.min.js
    modified:   plugins/editors/tinymce/tinymce.php

These are my file modifications after applying #14520 with PAtch Tester

mbabker commented 7 years ago

It doesn't patch files. It replaces files based on the contents of the remote branch. So if that branch is nowhere close to matching staging, that would cause side effects too.

Fedik commented 7 years ago

no need to save, no need to reinstall 😄 I can confirm the bug also, and I think I know the reason, but I will tell nothing :neckbeard:

well, if I get some free time I will make a fix

@Bakual try to add next fields in article XML, and you will get the same bug 😉

<field name="editor1" type="editor" 
    label="Text2" description="" filter="JComponentHelper::filterText"  />

<field name="editor2" type="editor" 
    label="Text3" description="" filter="JComponentHelper::filterText" />
dgrammatiko commented 7 years ago

@Fedik but you already told us 🤔

Bakual commented 7 years ago

@Fedik Ah I see, if "hide" isn't specified, then the bug is still present. My component has that specified and that's why it was fixed for me. I also had one button set to hide (due to doing testing) in my editor field which is the difference to the setup of @PhilETaylor.

PhilETaylor commented 7 years ago

ok I have manually applied every change in #14520 to f45c0da5ba84ef7538e13879a1b096ed9e05c24d and I can still replicate the reported issue

Im 100% convinced #14520 doesnt resolve this reported issue

Bakual commented 7 years ago

Closing this again since #14520 now fixes the issue for real 👍

PhilETaylor commented 7 years ago

This is fixed by #14520 @ 96603d295c396c173cb22825576af8d6ca4bdf0c - confirmed