search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

ConsoleApplication, Application, AbstractApplication constructor mistmatch causes lost of config #23038

Closed anibalsanchez closed 6 years ago

anibalsanchez commented 6 years ago

Steps to reproduce the issue

ConsoleApplication (extending Application) calls parent::__construct($input, $config);

But, Application constructor is __construct(Registry $config = null);

Then, Application (extending AbstractApplication) calls parent::__construct(null, $config);

Expected result

Configuration properly managed in ConsoleApplication.

Actual result

The config is being lost.

System information (as much as possible)

J4 A5

PhilETaylor commented 6 years ago

is this related to https://github.com/joomla/joomla-cms/issues/22931 https://github.com/joomla-framework/application/issues/84 @mbabker

mbabker commented 6 years ago

Sooner or later yes, after a composer update is done updating the joomla/console package.

joomla-cms-bot commented 6 years ago

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23038