search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

[4.0][a11y]Password field in Login form module has no label #23860

Closed zwiastunsw closed 5 years ago

zwiastunsw commented 5 years ago

Steps to reproduce the issue

  1. Set the Display icons option to Icons
  2. Check the source code

Expected result

It should be the label element "Password" for modlgn-passwd. Just as there is a label for modlgn-username.

Actual result

Currently, the label does not exist. Of course, when the Display icons option is set to Text, the label exist. Chrome and Firefox browsers show in the Accessibility tree that the item has an accessible name, NVDA screen reader announces this name, but testing tools (Audits in Chrome, tota11y, ANDI) report no label.

infograf768 commented 5 years ago

On it.

zwiastunsw commented 5 years ago

@infograf768 : Placeholder is not label :)

infograf768 commented 5 years ago

Yes, I am making the patch. This is what I meant with "On it"

infograf768 commented 5 years ago

Closing as we have a patch https://github.com/joomla/joomla-cms/pull/23862