search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.69k stars 3.63k forks source link

[4.0] Merge conflict from LDAP #25434

Open wilsonge opened 5 years ago

wilsonge commented 5 years ago

https://github.com/joomla-framework/ldap/commit/c7e30cea0859d977ec2e098ec3cf1c1347539eec

This was part of https://github.com/joomla/joomla-cms/pull/24115 however because we've moved to the LDAP package to symfony I can't map the new parameters as easily. So basically use the new params in #24115 to actually do something in j4

richard67 commented 5 years ago

One problem is that https://github.com/joomla-framework/ldap/commit/c7e30cea0859d977ec2e098ec3cf1c1347539eec hasn't been merged yet from the master branch into the 2.0-dev branch of the framework package, as far as I can see. This needs to be done before we can use it in 4.0-dev of the CMS.

mbabker commented 5 years ago

The LDAP package is deprecated and not getting a 2.0 release, it is replaced with Symfony's component as George's original comment noted.

richard67 commented 5 years ago

Ah, sure. Seems I have forgotten that after having read this issue.

Hackwar commented 3 months ago

@wilsonge can you check if this ticket still needs to stay open? It is 5 years old... And to be honest, I don't really understand it. 😄