[4.0] Choices css on filters

[brianteeman]

Sorry my scss-fu is not good enough to fix this - I can do some but not all. @angieradtke can you?

[ ] text color [ ] border-radius [ ] border color [ ] border color : focus [ ] box-shadow [ ] box-shadow : focus

[angieradtke]

select tags should like select access?

[angieradtke]

.choices.is-focused {border-color:#39f; box-shadow: 0 0 0 .2rem #d3e2f5;}

But.... it looks a little bit strange at the bottom

[brianteeman]

I have done most bits except for the part that makes the box-shadow when focused have rounded corners and not square ones - can't find that

[jwaisner]

Confirmed.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28272.}

[angieradtke]

ah now I understand. administrator/templates/atum/scss/vendor/choicesjs/choices.scss

` .choices__inner { border: $input-border; border-radius: $border-radius; box-shadow: $input-box-shadow; }

.choices.is-focused { .choices__inner { border-color: $focuscolor; box-shadow: $focusshadow

} }

`

[brianteeman]

thanks - will check it later and submit pr

[brianteeman]

did you check that - It doesnt impact on the focus box-shadow corners - they are still square

[angieradtke]

border-radius: $border-radius; ??? I have that

[brianteeman]

@angieradtke I dont know how you get this to work

It cannot work because $border-radius is not defined in

// Atum Variables
@import "../../variables";

[angieradtke]

it's a bootstrap var media/vendor/bootstrap/scss/_variables.scss

[brianteeman]

well your code still doesn't work for me - odd

[angieradtke]

hm?

What does the inspector  says? Do you get an error message?

Am 10.03.2020 um 10:30 schrieb Brian Teeman:

well your code still doesn't work for me - odd

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/joomla/joomla-cms/issues/28272?email_source=notifications&email_token=AAI6HM4FNAGX7EIDNX2X5LDRGYCD7A5CNFSM4LDZNA7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOKU56I#issuecomment-596987641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI6HMYDHENSFNFYZQ2FCBTRGYCD7ANCNFSM4LDZNA7A.

[brianteeman]

can you post an image of your successful inspector please

[angieradtke]

sure .-)

[brianteeman]

I still get the square corners

[infograf768]

Folks. you are not talking about the same thing @angieradtke your patch does work by adding a rounded shadow when the choice is limited to one item (select the category when editing an article.) It does not work when the choices is multiple (searchtools)

[angieradtke]

I'm confused

[angieradtke]

will update my branch

[infograf768]

Select condition, select stage, select language etc, do not use fancyselect and choices.

Select category, Select author, Select Tag do (in searchtools), but they are multiple choices fields. Select category when editing an article is a single choice.

[brianteeman]

Based on the class names that @angieradtke mentioned she is talking about the correct place

[infograf768]

The problem is not the class name. What I am trying to explain is that her patch works when fancy select is set to select-one, NOT when fancyselect is set to multiple... TBH I don't care about such petty issues. There are more important stuff to deal with.

[brianteeman]

Sorry you are completely wrong. And if you don't care then don't comment. You don't have to comment on everything

[infograf768]

GL

[angieradtke]

it's a browser issue. Firefox has rounded corners, will take a look

[angieradtke]

the border-radius has to go to :

.choices { border: 0; border-radius:$border-radius; }