Error in Joomla calendar

[balvard]

Steps to reproduce the issue

file : media/system/js/fields/calendar-locales/date/jalali/date-helper.js Error : This function not return required data

Date.prototype.getLocalMonthDays = function(dateType, month) {
    if (dateType != 'gregorian') {
        /** Modify to match the current calendar when overriding **/
        var year = this.getLocalFullYear('jalali');
        if (typeof month == "undefined") {
            month = this.getLocalMonth('jalali');
        }
        if (((0 == (year%4)) && ( (0 != (year%100)) || (0 == (year%400)))) && month == 1) {
            return 29;
        } else {
            Date.local_MD[month]; <=== Error : Must be returned this value
        }
    } else {
        var year = this.getFullYear();
        if (typeof month == "undefined") {
            month = this.getMonth();
        }
        if (((0 == (year%4)) && ( (0 != (year%100)) || (0 == (year%400)))) && month == 1) {
            return 29;
        } else {
            return Date.gregorian_MD[month]; <==== Like this
        }
    }
};

Expected result

This is Expected

Date.prototype.getLocalMonthDays = function(dateType, month) {
    if (dateType != 'gregorian') {
        /** Modify to match the current calendar when overriding **/
        var year = this.getLocalFullYear('jalali');
        if (typeof month == "undefined") {
            month = this.getLocalMonth('jalali');
        }
        if (((0 == (year%4)) && ( (0 != (year%100)) || (0 == (year%400)))) && month == 1) {
            return 29;
        } else {
            return Date.local_MD[month];
        }
    } else {
        var year = this.getFullYear();
        if (typeof month == "undefined") {
            month = this.getMonth();
        }
        if (((0 == (year%4)) && ( (0 != (year%100)) || (0 == (year%400)))) && month == 1) {
            return 29;
        } else {
            return Date.gregorian_MD[month];
        }
    }
};

Actual result

System information (as much as possible)

Additional comments

[balvard]

And This function has same error Date.prototype.getMonthDays

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28698.}

[infograf768]

@balvard Could you please add screenshots of the Jalali results obtained in both cases, i.e. with return and without the return, for a said Gregorian date?

@dgrammatiko Any possible error here?

[dgrammatiko]

@balvard @infograf768 yes a return is required as correctly stated above.

[infograf768]

OK. You make patch or I do?

[brianteeman]

(reset priority according to our defined criteria)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28698.}

[dgrammatiko]

You make patch or I do?

If you're referring to me please do the PR (or maybe @balvard would like to do that)

[infograf768]

will do as we also need a minified, but testing now differences first.

[infograf768]

Please see patch https://github.com/joomla/joomla-cms/pull/28700

@balvard Please explain there the display differences with screenshots. Closing this as we have a patch.