joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.75k stars 3.64k forks source link

[4.0] Media Manager - Can't preview entire image #29149

Closed C-Lodder closed 3 years ago

C-Lodder commented 4 years ago

Steps to reproduce the issue

  1. Download https://unsplash.com/photos/xnEZYWmfPwU/download?force=true (original size)
  2. Upload to the Media Manage or place in your images directory
  3. Double click the image to preview it

Expected result

Full image is shown (scaled down) or the ability to move the image about

Actual result

Half the image is cropped and you cannot scroll down to view the other half

ghost commented 4 years ago

Issue confirmed.

brianteeman commented 4 years ago

I am not a css gut but the problem is valid and is coming from .media-preview-modal .modal-dialog {

.media-preview-modal {
  color: $modal-preview-text-color;

  .modal-dialog {
    max-width: 70vw;
    max-height: 70hw;
}

I can make it nice for portrait images or landscape images but not both. I am sure a css guru can fix it

Quy commented 3 years ago

Please test PR #33323