Usability Issue in Joomla when filter text

B3nito commented 4 years ago

Is your feature request related to a problem? Please describe.

When you are a enduser and use an editor and plugin settings is filtering input then html is just stripping out of text.

Describe the solution you'd like

User should get notification that html was cleaning for plugin settings so better usability

Additional context

I have problem in custom fields that filter is enabled default and user thought that Joomla is buggy. User should know what system is do automatically.

Ayushsunny commented 3 years ago

Is this issue still persist?

pank1999 commented 3 years ago

i want to solve this issue please guide me

Nitesh639 commented 3 years ago

I want to solve this issue.

Yash-g17 commented 3 years ago

@HLeithner I'd love to work on this issue , can you please assign and guide me ?

brianteeman commented 3 years ago

The Joomla Project doesn't assign issues to contributors in that way. Just work on it and submit a PR :-)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

Ayushsunny commented 3 years ago

The Joomla Project doesn't assign issues to contributors in that way. Just work on it and submit a PR :-)

https://github.com/joomla/joomla-cms/blob/staging/.github/CONTRIBUTING.md

is there any mentor who can help us to solve this issue?

abhijha0602 commented 3 years ago

I want to solve this issue

ghost commented 3 years ago

Just work on it and submit a PR :-)

imtiyaj786 commented 3 years ago

how can i check this issue in own ?

ReLater commented 3 years ago

Hello volunteers,

You don't have to ask if you are allowed to take over an issue.
- Identify the issue in an installation of Joomla. Use a nightly build for it: https://developer.joomla.org/nightly-builds.html
- Try to find a code solution for the issue after you have checked whether it really exists.
- If it exists confirm it here in the issue for the sake of completeness. A "I'll take over" is a good hint for others that don't waste their time then with it.
- Test your solution.
- Finally provide a pull request on GitHub (= "here") that others can test. If tests are not successful you can change and discuss your pull request for further tests.
- Sometimes others provide a "suggestion" that you can merge directly by clicking in your PR.
There are no mentors to accompany you. It goes without saying that you can ask the general public how this or that works. I think (don't know) that the "Discussions" tab above can be a good place for more general questions.
Here is a doc how to create pull requests via browser GUI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
If you want to go deeper you could also work with a git repository tool on your local machine. Needs some more skills and time to learn:

amankothiyal04 commented 3 years ago

hey @B3nito can you help me with this issue want to contribute to solve it

Shaveetha commented 3 years ago

I would like to solve this issue. Can you please guide me.

brianteeman commented 3 years ago

@Shaveetha @amankothiyal04

Hello volunteers,

You don't have to ask if you are allowed to take over an issue.

Identify the issue in an installation of Joomla. Use a nightly build for it: https://developer.joomla.org/nightly-builds.html

Try to find a code solution for the issue after you have checked whether it really exists.

If it exists confirm it here in the issue for the sake of completeness. A "I'll take over" is a good hint for others that don't waste their time then with it.

Test your solution.

Finally provide a pull request on GitHub (= "here") that others can test. If tests are not successful you can change and discuss your pull request for further tests.

Sometimes others provide a "suggestion" that you can merge directly by clicking in your PR.

There are no mentors to accompany you. It goes without saying that you can ask the general public how this or that works. I think (don't know) that the "Discussions" tab above can be a good place for more general questions.

Here is a doc how to create pull requests via browser GUI: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

If you want to go deeper you could also work with a git repository tool on your local machine. Needs some more skills and time to learn:

brianteeman commented 3 years ago

Can you please remove the "good first issue label" as its absolutely not a simple thing to fix (not sure if its even possible)

HLeithner commented 3 years ago

I don't think it's too hard.

I would solve this issue with 5 lines of code (without looking in deep, only looked at com_content)

Adding $original = $text at this position: https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Component/ComponentHelper.php#L126

And a if ($text !== $original) { JFactory::getApplication()->enqueueMessage('JHTML_FILTER_MODIFY', CMSApplicationInterface::MSG_WARNING); } at line https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Component/ComponentHelper.php#L295

Of course the language string have to be added too. But maybe I think too simple and missed something ymmv

brianteeman commented 3 years ago

That won't work for text filtering where the editor eg tinymce is doing the filtering
To be useful it really should say what has been filtered

HLeithner commented 3 years ago

is not possible (at least I can't think of a working solution)
I'm pretty sure there is a way to achieve this for tinymce in js too

brianteeman commented 3 years ago

Its still not a "good first issue" which was the point of my post

HLeithner commented 3 years ago

Why not? it's easy to fix, the first parts are only 5 lines of code.

What would you say what's a good first issue is, If you find one I would really like to tag it.

brianteeman commented 3 years ago

If it was so easy then any one of the 10 people who said they wanted to fix it would have been able to or anyone else for that matter in the months since november. plus if its really so easy then you would have submitted it instead of debating a pointless argument with me.