joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.74k stars 3.65k forks source link

[4.0] Featured button [a11y] #33296

Closed brianteeman closed 3 years ago

brianteeman commented 3 years ago

Multiple issues

Featured Article

~1. Icon uses color alone to indicate its status~

  1. Screen reader only announces "Toggle Featured Status" - it does not announce if it is featured or not
  2. Still uses bootstrap tooltip

image

Featured Contact

~1. icon uses color alone to indicate its status~

  1. Screen reader only announces "Feature Item" or "Unfeature item" - it does not announce if it is featured or not

image

Summary

~- Update icon~

updated after #33417

himanshu007-creator commented 3 years ago

To solve this, an approach can be using different but similar icons for featured and unfeatured status of article. featured state icon:- https://fontawesome.com/icons/lightbulb-on?style=solid unfeatured state icon:- https://fontawesome.com/icons/lightbulb-slash?style=duotone

On screen , it will go like:-

state: <_present state_> click to toggle

richard67 commented 3 years ago

@himanshu007-creator The icons you are suggesting belong to the "pro" package of fontawesome, which is a paid one. We only ship the free ones, "standard", "solid" and "brands".

chmst commented 3 years ago

We could show no star at all if an item is not featured.

himanshu007-creator commented 3 years ago

@himanshu007-creator The icons you are suggesting belong to the "pro" package of fontawesome, which is a paid one. We only ship the free ones, "standard", "solid" and "brands".

Okay, if that is the case, maybe an eye icon will do the job! Moreover , it will look quite self explanatory as well! featured state icon-https://fontawesome.com/icons/eye?style=solid unfeatured state icon- https://fontawesome.com/icons/low-vision?style=solid

views:- featured unfeatured

PhilETaylor commented 3 years ago

Not only the featured articles icon - if you go to Template Styles here is the same issue with the default icon

Screenshot 2021-04-25 at 16 28 24
PhilETaylor commented 3 years ago

Okay, if that is the case, maybe an eye icon will do the job!

"Eye" is used for "preview" elsewhere in Joomla - Eg, the template styles screenshot I just posted

himanshu007-creator commented 3 years ago

Okay, if that is the case, maybe an eye icon will do the job!

"Eye" is used for "preview" elsewhere in Joomla - Eg, the template styles screenshot I just posted

we can change the default icon here as well to a single tick icon like this A site can have many published articles, but there is only one default template for a category (site of admin). For this case we can use a single tick in front of the template selected as default and for rest templates, leave it blank. 2021-04-25 (2)

carcam commented 3 years ago

Featured and default are different states. So having different icons for them makes total sense.

Looking for options and taking into account that an article can be featured in a specific container and it's like a windows shop, I think the store icons could do the job:

https://fontawesome.com/icons/store-slash?style=solid

https://fontawesome.com/icons/store?style=solid

For template manager, I will leave the tick for default and an empty circle for non-default items.

chmst commented 3 years ago

Agree that featured and default are different.

I prefer the star as it is for feaured items, this is a common icon and users know it. If an item is not featured, we could use the "disc" - this is also common and known - used in menu items overview.

alikon commented 3 years ago

please test #33417

richard67 commented 3 years ago

Re-opening since PR #33417 is only for parts of this issue, see https://github.com/joomla/joomla-cms/pull/33417#issuecomment-829912307 .

brianteeman commented 3 years ago

thanks @richard67 I have updated the original post

chmst commented 3 years ago

I have stopped working on the issue as @brianteeman took over.

brianteeman commented 3 years ago

Sorry. I didn't know you were working on it. You didn't say anything.

richard67 commented 3 years ago

She had assigned the issue to herself, which was visible on GitHub by the "asignee".

brianteeman commented 3 years ago

when did we start using that? also its not very productive as only a limited few people can even use it

richard67 commented 3 years ago

We started to use it years ago, but you are right, we used it only in rare cases.

chmst commented 3 years ago

Indeed it is not as easy to solve this issue, but important - because the tooltips also are different for workflow on/off.

brianteeman commented 3 years ago

Once again apologies for not seeing the assignment. Might be a good idea for you to review the current assignments ;)

chmst commented 3 years ago

no problem - now as your changes of the icon are merged I can continue.

brianteeman commented 3 years ago

sorry once again

ghost commented 3 years ago

@chmst i fear it will happen again cause the self-assign isn't shown on top:

image

richard67 commented 3 years ago

@sandramay0905 That's because I have remove the assignment after @chmst had asked me on Glip to do so.

ghost commented 3 years ago

@richard67 sorry, i thought its a general problem. Thanks for the information :-)

chmst commented 3 years ago

Closing as there is a PR

richard67 commented 3 years ago

See #33557 .