joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.79k stars 3.66k forks source link

Joomla 4: $db->loadObjectList('id', MenuItem::class) fails on Unknown fetch type '8' #35452

Closed mahagr closed 2 years ago

mahagr commented 3 years ago

Steps to reproduce the issue

use Joomla\CMS\Menu\MenuItem;

$db = \JFactory::getDbo();
$query = $db->getQuery(true)
    ->select('m.id, m.menutype, m.title, m.alias, m.note, m.path AS route, m.link, m.type, m.level, m.language')
    ->select($db->quoteName('m.browserNav') . ', m.access, m.params, m.home, m.img, m.template_style_id, m.component_id, m.parent_id')
    ->select('e.element as component')
    ->from('#__menu AS m')
    ->join('LEFT', '#__extensions AS e ON m.component_id = e.extension_id')
    ->where('m.menutype = ' . $db->quote($menutype))
    ->where('m.parent_id > 0')
    ->where('m.client_id = 0')
    ->where('m.published >= 0')
    ->order('m.lft');

// Set the query
$db->setQuery($query);

$list = $db->loadObjectList('id', MenuItem::class);

Expected result

The query should work just as it worked in Joomla 3.9/3.10.

Actual result

Exception: Unknown fetch type '8'. This seems to happen when using mysqli but not when using dbo.

System information (as much as possible)

PHP 8.0.10 / 7.4.23

Additional comments

Following workaround works (replace the last line):

$list = [];
foreach ($db->loadAssocList('id') as $id => $data) {
    $list[$id] = new MenuItem($data);
}
mahagr commented 3 years ago

Bug is located in MysqliStatement::fetch() method. I compared it with SqlsrvStatement::fetch() which takes the constant into consideration.

richard67 commented 3 years ago

... which takes the constant into consideration.

@mahagr Which constant do you mean? And I think the issue should be reported here: https://github.com/joomla-framework/database as it's in the database driver. Or am I wrong?

mahagr commented 3 years ago

FetchMode::CUSTOM_OBJECT isn't being handled. I will make a new issue to the DB repository.

mahagr commented 3 years ago

Please do not close this issue until you have updated the framework in CMS as it's a B/C break in Joomla.

richard67 commented 3 years ago

Thanks. Yes, we'll leave it open as reminder.

mahagr commented 3 years ago

@richard67 See the response in the Joomla Framework issue.

richard67 commented 3 years ago

@richard67 See the response in the Joomla Framework issue.

@mahagr Yes, I saw. Here the link for reference for other readers: https://github.com/joomla-framework/database/issues/254#issuecomment-910450635 . I'm not sure now what to do with this issue here.

mahagr commented 3 years ago

Do we have the same version of Framework in Joomla 3.10?

I think the best way to deal with the issue is to have a better error message instead of the one from above. It is a compatibility issue for sure; older versions of Joomla accepted custom classes with all DB engines. Luckily it is something that is generally very easy to fix, but in my case, I totally missed it as I'm using PDO for testing.

Also, should Joomla! 4 use PDO by default?

richard67 commented 3 years ago

3.10 and 4 use different versions of the Framework. Why PDO hasn't been chosen as default for new installations I don't know.

mahagr commented 3 years ago

@mbabker Any idea why Joomla 4 doesn't use PDO by default?

joomdonation commented 2 years ago

Base on the discussion I read from the framework repo https://github.com/joomla-framework/database/issues/254#issuecomment-910450635 , there would be no change to support the issue mentioned here. Anyone has this issue, please use the provided workaround:

$list = [];
foreach ($db->loadAssocList('id') as $id => $data) {
    $list[$id] = new MenuItem($data);
}

With that said, I'm closing this issue here.