search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

Remove hard-limit of 20 to the Module Tags-Popular list size #36016

Closed pwireless closed 2 years ago

pwireless commented 2 years ago

Steps to reproduce the issue

Create new Module Tags-Popular. It's not allowed to show more than 20 tags.

Expected result

Show more than 20 tags. Have a high limit e.g. 500.

Actual result

System information (as much as possible)

Additional comments

alikon commented 2 years ago

you can change the default max here https://github.com/joomla/joomla-cms/blob/4.0-dev/modules/mod_tags_popular/mod_tags_popular.xml#L43

brianteeman commented 2 years ago

It wouldnt be "popular" tags if there were 500

chmst commented 2 years ago

In other modules (polular articles, most read articles) we use type=number and leave it to the user how many itemshe wants to see.

brianteeman commented 2 years ago

It has had a maximum of 20 since Elin introduced the code 9 years ago - just saying

HLeithner commented 2 years ago

I see no technical reason for the limit. if you write a pull request to remove this restriction I would support it.

chmst commented 2 years ago

Please test #36019

richard67 commented 2 years ago

@chmst Why reopened? Isn't there a pull request which claims to fix it?

Quy commented 2 years ago

@richard67 it was reopened before #36261.

richard67 commented 2 years ago

Ah … ok.

Closing as having a pull request. Please test #36261 . Thanks in advance.