joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.7k stars 3.63k forks source link

[4.1] Accessibility plugin is not accessible #37210

Open drmenzelit opened 2 years ago

drmenzelit commented 2 years ago

Steps to reproduce the issue

Activate the plugin System - Additional Accessibility Features, no matter if backend, frontend or both. Try to access the button using the hotkey CTRL + ALT + A (Windows) or using the keyboard.

Expected result

You can open and operate the function from the plugin without a mouse.

Actual result

It is impossible to reach the button using the keayboard. The hotkey is not working either (tested in Firefox and Chrome on Windows).

System information (as much as possible)

Joomla 4.1.1-dev

Additional comments

The icons look very weird, that seems to be related with this PR: https://github.com/joomla/joomla-cms/pull/36948 grafik

The wheel chair icon should be replaced by the newer accessibility symbol grafik

brianteeman commented 2 years ago

Do these work for you? (They do for me)

Module or Function | Hotkey -- | -- Toggle Menu | CTRL + ALT + A Gray Hues | CTRL + ALT + G Underline Links | CTRL + ALT + U Big Cursor | CTRL + ALT + C Reading Guide | CTRL + ALT + R Text To Speech | CTRL + ALT + T Speech To Text | CTRL + ALT + S
drmenzelit commented 2 years ago

CTRL + ALT + A -> doesn't work CTRL + ALT + G -> is deactivated in Firefox, it works in Chrome CTRL + ALT + U -> it works CTRL + ALT + C -> it works CTRL + ALT + R -> it works CTRL + ALT + T -> it works CTRL + ALT + S -> is deactivated

One can see the hotkeys in the code, but they are not explained in the plugin.

brianteeman commented 2 years ago

they are explained in the plugin upstream documentation. I cant explain why ctr-alt-a doesnt work for you as I cant replicate it. Everything else that is wrong with this plugin is because the JAT at the time insisted on having this type of plugin and after initial implementation changed their minds and then subsequently people forced incorrect changes upstream which broke everything.

chmst commented 2 years ago

CTRL + ALT + A opens the skip-to-nativation here but not the accessibility plugin. (win 11) I have all a11y plugins enabled in backend and frontend. Maybe this causes conflicts.

cyrezdev commented 2 years ago

The wheel chair icon should be replaced by the newer accessibility symbol

👍

I could create a PR to update the icon, but i don't find anymore the media folder in github repository...?

brianteeman commented 2 years ago

CTRL + ALT + A opens the skip-to-nativation here but not the accessibility plugin. (win 11)

That is weird - it should be alt+9

Alam9835 commented 2 years ago

I want to work on this issue.

drmenzelit commented 2 years ago

Iit is not necessary to ask for permission to work on an issue. @Alam9835 if you are a GSoC student you can join the accessibility project.

chmst commented 2 years ago

Additional info: The key combination of Control + Option + A is already reserved on a Mac by the VoiceOver application and is set to make VoiceOver start reading from where the cursor / pointer is located.

h-tagliato commented 1 year ago

Really exhaustive. Thank you very much for your explanations


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37210.

ahotzler commented 1 year ago

Slightly OT: In the screenshot above, the icons are inappropriate in my eyes.

Is that supposed to be so that a steering wheel can be seen with "Invert Colours"? The "100" at "Underline left" also makes 0 sense.

I notice this on some pages, moreover the representation of the shown icons is different on different computers (sometimes colored, sometimes gray).

The screenshot shows the output when the plugin is set to the option "Emojis", here no Google Material Fonts are loaded.

If you also see this as inappropriate, I would report a bug.

drmenzelit commented 1 year ago

We are aware of the emojis. Since the plugin loads an external library, we can't directly change it. This year we had a GSoC student working on the plugin. We hope to bring some improvements in the next Joomla version. And maybe we would be able to use an own set of SVG icons instead of the emojis.

ahotzler commented 1 year ago

Ok thanks, if I can add anything with my humble knowledge let me know.

Quy commented 1 year ago

Related #39161

sandewt commented 1 year ago

Related #39615

Quy commented 3 months ago

This will be fixed with #43143.