bascherz
commented
10 months ago I switched to using a monthly interval for this particular case. It turns out the basic issue is that when scheduling, say, a monthly interval, a specific day of the month is entered. But instead of using that information to determine the next scheduled execution time, it is using the last time the task ran (e.g., Test Run) plus the selected interval (a month in this case).
The code below is from ExecRuleHelper.php. Based on the comments, it appears to be unfinished. Clearly in the case for 'interval', no attempt to use the specified day-of-month is made. The $nextExec is clearly only ever based on $lastExec.
/**
* @param boolean $string If true, an SQL formatted string is returned.
* @param boolean $basisNow If true, the current date-time is used as the basis for projecting the next
* execution.
*
* @return ?Date|string
*
* @since 4.1.0
* @throws \Exception
*/
public function nextExec(bool $string = true, bool $basisNow = false)
{
// Exception handling here
switch ($this->type) {
case 'interval':
$lastExec = Factory::getDate($basisNow ? 'now' : $this->getFromTask('last_execution'), 'UTC');
$interval = new \DateInterval($this->rule->exp);
$nextExec = $lastExec->add($interval);
$nextExec = $string ? $nextExec->toSql() : $nextExec;
break;
case 'cron-expression':
// @todo: testing
$cExp = new CronExpression((string) $this->rule->exp);
$nextExec = $cExp->getNextRunDate('now', 0, false, 'UTC');
$nextExec = $string ? $this->dateTimeToSql($nextExec) : $nextExec;
break;
default:
// 'manual' execution is handled here.
$nextExec = null;
}
return $nextExec;
}The workaround until the above code is completed is to edit the database table #__schedulertasks and set next_execution to the date/time you want after any test run.
As for the cron-expression case, I am not sure what the issue was there but it is likely it's similar to the interval case. This code just does not appear to be finished yet.
rdeutz
Steps to reproduce the issue
I do not know if this is reproducible. It happened on a live site and I don't have time to mess with it. But this is what happened.
I had the task setup using the "Cron Expression" interface to run at 10 after midnight (5:10am UTC) on the 20th of every month (all weekdays selected). The job executed on Dec 02, 2023. The task is a Community Builder unconstrained task that runs a custom php script that has been thoroughly tested using the Task Scheduler's "Run Test". When run manually, there has never been an error like this one.
Screenshot
Expected result
I expected the task to run on the 20th, not the 2nd, without errors.
Actual result
Here is the log file from the erroneous run:
System information (as much as possible)
Software: Joomla! 4.4.1 Stable [ Pamoja ] 28-November-2023 16:00 GMT PHP Built On: Linux 4.18.0-477.10.1.lve.el8.x86_64 #1 SMP Wed May 17 07:12:55 EDT 2023 x86_64
Database Type: mysql
Database Version: 10.6.16-MariaDB
PHP Version 8.1.25
Server API: LiteSpeed V8.1 Cloudlinux 1.3
Community Builder: v2.9.0, Auto Actions: v9.1.0+build.2022.10.14.14.57.50.7b1989310
Additional comments
I am now trying the Interval scheduling method. The task has not yet executed. I expect it to run on 2023-12-23.