search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.69k stars 3.63k forks source link

[5.1]update to 5.1.0 beta2 fails #43109

Open jschmi102 opened 3 months ago

jschmi102 commented 3 months ago

Steps to reproduce the issue

Update from 5.1.0 beta1 to 5.1.0 beta2

Expected result

Update should work sucessfully

Actual result

grafik

System information (as much as possible)

update.php content after failure:

<?php
defined('_JOOMLA_UPDATE') or die('Restricted access');
$extractionSetup = [
    'security.password' => '8949wO0mG7qpOIXAkcITY6sHnIBcxaH2',
    'setup.sourcefile' => 'c:\myjoomla4/tmp/1289e417-796e-420e-a9bc-15107efb2770',
    'setup.destdir' => 'C:\myjoomla4',];

file permissions (e.g. for update.php or extract.php) are all OK
C:/myjoomla4/tmp contains file denoted by update,php

Additional comments

alikon commented 3 months ago

related to #43100

jschmi102 commented 3 months ago

hi, I don't think its related to #43100 as results are total different, I fixed the problem by doing folowing;

  1. use/copy extract.php from a joomla 5.0.3 system
  2. run update with copied file

I could not check the cause/difference of joomla's 5.1.0-beta1 extract.php - but it seems to be very clear that using extract.php of 5.1.0-beta1 caused the problem. What puzzles me is the fact that using a different extract.php file with exactly same content updates joomla without problem.

Updated system to 5.1.0-beta2 works fine and I do not see any problems yet.

jschmi102 commented 3 months ago

hi, I thought because of file size content was the same, but then I checked with "https://www.textcompare.org/" and found some differences (e.g. at lined 1524, 1551, 1564):

line 1564 - 5.1.0 => if ($this->binStringLength($zipData) < $this->fileHeader->compressed) line 1564 - 5.0.3 => while ($this->binStringLength($zipData) < $this->fileHeader->compressed)

can anybody clarify?

Hackwar commented 3 months ago

I tested updating a fresh Joomla 5.1.0 beta 1 site with an update package to 5.1.0 beta2 on windows and it worked fine. Can you give more information to your setup so that we can replicate this?

jschmi102 commented 3 months ago

I'm using this system as a joomla testing site. Its brief history is sofar:

I've attached extract.php (as extract.php.txt) of joomla v5.1.0-beta1 from march 4, 2024 extract.php.txt

Hackwar commented 3 months ago

Would it be possible to get a copy of the site?

jschmi102 commented 3 months ago

hi, no, sorry because of (privacy) information contents cannot do this. As extract.php from 5.1.0-beta2 is the same as with 5.1.0-beta1 i will see if same problems happen when upgrading to 5.1.0-RC on april, 2. (or if this was just an intermediate problem).

jschmi102 commented 3 months ago

maybe this might help - checked logfile ""joomla.update.php" and found this:

2024-03-09T15:09:13+00:00   INFO 127.0.0.1  update  Test logging
2024-03-09T15:09:13+00:00   INFO 127.0.0.1  update  Update started by user jochen (62). Old version is 5.1.0-beta1.
2024-03-09T15:09:15+00:00   INFO 127.0.0.1  update  Downloading update file from https://objects.githubusercontent.com/github-production-release-asset-2e65be/2464908/3291752f-fac1-46d8-82ca-95d04a0cb69a?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20240309%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240309T150914Z&X-Amz-Expires=300&X-Amz-Signature=d1698e17ea5a5788d6c72caae0215d4168c6123ed22f2793c8478cda84d28477&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=2464908&response-content-disposition=attachment%3B%20filename%3DJoomla_5.1.0-beta1-Beta-Update_Package.zip&response-content-type=application%2Foctet-stream.
2024-03-09T15:09:18+00:00   ERROR 127.0.0.1 update  The version of the update package and the requested version do not match, try to refresh the update information

Found this error only once all subsequent (failed) tries did not show any errors or warnings until successful update to 5.1.0-beta2.

HLeithner commented 3 months ago

that's an error for the beta1 download 2 weeks ago so should be unrelated to beta2