search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.7k stars 3.63k forks source link

[5.x] non minified css #43241

Open brianteeman opened 3 months ago

brianteeman commented 3 months ago

Is it intentional that we only ship the non-minified css for awesomplete jquery-minicolors chosen

or is it a bug in our build scripts?

dgrammatiko commented 3 months ago

Is it intentional that we only ship the non-minified

yes, these packages do not provide non minified versions, thus the npm build script has exceptions for those

brianteeman commented 3 months ago

so why dont we minify them?

dgrammatiko commented 3 months ago

Actually I was wrong here, the part that I was referring is about JS: https://github.com/joomla/joomla-cms/blob/c594155371fc5c8efdf3039d4de6a80fc09068c3/build/build-modules-js/init/minify-vendor.es6.js#L8

About the css you're asking:

Although you're right and these files should've both a minified and a non minified version this needs an exception in the tooling. IMO all these packages could/should be dropped instead of patching them here...

brianteeman commented 3 months ago

keeping them or dropping them is a different discussion. There might be other vendor files that only ship non-minified css in the future

while they are present they should be minified and the tooling needs to be updated to do this.