Open o-joomla-issues opened 6 months ago
dgrammatiko
commented
6 months ago Happens with empty bmp,gif,jpg,jpeg,png files but not with ico,pdf,svg
It's expected (code wise). The mime of the image files are checked through PHP functions which will obviously fail for an empty image: https://github.com/joomla/joomla-cms/blob/45adb61f8306b945f43b4326305fafe87c154aa2/libraries/src/Helper/MediaHelper.php#L86-L125
FWIW I had proposed a safer, faster alternative some time ago...
Kubik-Rubik
commented
6 months ago Such broken image files should be appropriately caught and displayed with a corresponding icon:
Please try to set the error level to None in the global settings and load the Media Manager again.
o-joomla-issues
commented
6 months ago With error reporting set to none the folder contents is displayed as expected. I can see the above image. With error reporting set to standard the initial issue shows up.
Additional info: browser console shows:
VM201:1 Uncaught SyntaxError: Unexpected token '<', "
"... is not valid JSON
at JSON.parse (
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43279.
o-joomla-issues
commented
6 months ago With error reporting set to simple the folder contents is displayed as expected also.
Kubik-Rubik
commented
6 months ago Yes, this is expected behaviour in this case. If PHP writes errors, notices or warnings into the output, the JSON response is no longer valid, and the Media Manager cannot process the response correctly. So, this is the symptom of the issue but not the source.
We should ensure that built-in PHP calls to retrieve image information do not create such errors because a 0-byte image is processed like a valid one.
I solved it years ago in my extensions by checking for the file size first before running any further calls on the file. We could also apply the same logic to the local adapter for the Media Manager.
richard67
commented
6 months ago We could also apply the same logic to the local adapter for the Media Manager.
I think that should be done, and as it’s a bug fix it should be done for the 4.4-dev branch if the issue happens also with 4.4.x. It will later be merged up into 5.1-dev by release managers.
ralain
commented
5 months ago We had a possibly related issue on a customer's site where they had uploaded an animated gif. This triggered the error:
imagecolorsforindex(): Argument #2 ($color) is out of range
in the Media Manager, and no images loaded.
Turns out Create Thumbnails was enabled in the "FileSystem - Local" plugin. Disabling Create Thumbnails fixed the error.
Animated gifs trigger the error on both 4.4 and 5.1 when Create Thumbnails is enabled.
fgsw
commented
3 weeks ago and as it’s a bug fix - https://github.com/joomla/joomla-cms/issues/43279#issuecomment-2058743359
@richard67 The issue hasn't the label bug.
Quy
commented
1 day ago @ralain See PR #44418
Steps to reproduce the issue
Upload empty bitmap image (bmp,gif,jpg,jpeg,png) (or on console: touch test.png)
Expected result
File list with all existing images
Actual result
Empty file list, no files are shown, not even non-zero files URL changes to include folder name Folder in left column folder is not highligted as "current"
System information (as much as possible)
Joomla! 5.0.3 PHP 8.3.4 as fpm-fcgi on nginx
Additional comments
Happens with empty bmp,gif,jpg,jpeg,png files but not with ico,pdf,svg File list shows properly if you remove the empty images or rename them top non-image file extension