Save & new and save as copy buttons dissappear from article editor in com_content after upgrading to 3.3.4

[isidrobaq]

Steps to reproduce the issue

1) Upgrade to 3.3.4 2) Edit an article in com_content. Buttons "Save & new" and "Save as copy" are not there

Expected result

Those buttons should be there.

Actual result

Buttons are not there

System information (as much as possible)

Database Version 5.5.38-0ubuntu0.12.04.1 PHP Version 5.3.10 Web Server Apache/2.2.22 (Ubuntu) WebServer to PHP Interface cgi-fcgi

Additional comments

[betweenbrain]

I am unable to reproduce this with two different sites and servers.

One is:

Database Version 5.5.38-0ubuntu0.12.04.1 PHP Version 5.3.10-1ubuntu3.14 Web Server Apache/2.2.22 (Ubuntu) WebServer to PHP Interface apache2handler

The other is:

Database Version 5.6.19-1~dotdeb.1 PHP Version 5.5.17-1~dotdeb.1 Web Server nginx/1.6.2 WebServer to PHP Interface fpm-fcgi

@isidrobaq - could this be a browser cache issue?

[Bakual]

I can confirm it. And it looks like the permission for core.create is missing. It's calculated here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/views/article/view.html.php#L48

I'm not yet sure why it fails.

[mbabker]

This patch did it - https://github.com/joomla/joomla-cms/commit/49058f3190dae2820c28deb5d98b0957aec1b579

Previously, the component permissions were always checked. Now, the section permissions are checked if it's injected. We're passing in the article section at that point, which doesn't have the core.create permission.

Weblinks is coded right. The checks there are against the parent category as that has the full permission set (and you need that to do certain things).

[brianteeman]

I can confirm this issue as well

[betweenbrain]

Interesting that it doesn't seem to affect all sites.

[peterlose]

I can reproduce the issues as well.

I don't know if this is related to this issue, but after upgrading I'm missing "Configure Edit Screen" and "Permissions" from the article view

[zero-24]

yes @losedk if you revert the commit https://github.com/joomla/joomla-cms/commit/49058f3190dae2820c28deb5d98b0957aec1b579 this is also fixed.

[brianteeman]

@losedk I can confirm they are missing as well

@betweenbrain I can confirm this on upgrades and fresh installs both with and without sample content

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

[peterlose]

@zero-24 Yeah, just reverted it. It does indeed fix the problem

[betweenbrain]

@brianteeman I'm not doubting that you can confirm this, just wondering why it doesn't seem to affect all sites.

[brianteeman]

@betweenbrain are the sites that you hae that are not effected with custom acl rules? Thats the only thing I can think of that would explain it

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

[betweenbrain]

@brianteeman No, both are about as basic / core as it can get. One is even a 3.3.3 install without sample data. I was thinking ACL too, but I haven't touched it on either site. Also tested with a non Super User and that user can see the buttons. Odd as it seems like it ought to be broken on all sites.

But, as long as other can confirm the issue and fix, I guess we're good.

[tanasebutcaru]

I can confirm both buttons (Save&new / Save as copy) and tabs (Permissions / Configure edit screen) missing on a fresh install of 3.3.4 (no sample data) and on an existing website with 3.3.3 before update.

PHP 5.4.27 Database: 5.5.36 Webserver Apache/2.4.9 (Archlinux)

[Bakual]

Closing this issue in favor of #4331 which should fix it. Please test and comment on the PR. Thanks.

[stellainformatica]

Please note that creating a new article the buttons "Save as Copy" and "Versions" disappear. Probably the reverting fixes also this case, please Bakual create a new PR to test it, thanks ;)

[stellainformatica]

Sorry, the "Save as Copy" and "Versions" buttons hasn't obviously to appear in a new article...

[uzielweb]

The patch works fine. Thanks. https://github.com/joomla/joomla-cms/pull/4331/files

libraries/cms/helper/content.php Line 124

Change >>>>>

$actions = JAccess::getActionsFromFile($path, "/access/section[@name='" . $section . "']/");

By >>>>>>>

$actions = JAccess::getActionsFromFile($path, "/access/section[@name='component']/");

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

[gmng]

I have cheked it and missing "save as copy" and "save and new" buttons.

PHP Built On Linux 3.2.0-4-686-pae #1 SMP Debian 3.2.51-1 i686 Database Version 5.5.38-0+wheezy1 Database Collation utf8_general_ci PHP Version 5.4.4-14+deb7u14 Web Server Apache/2.2.22 WebServer to PHP Interface apache2handler Joomla! Version Joomla! 3.3.4 Stable [ Ember ] 23-September-2014 14:00 GMT Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT

[PhocaCz]

Hi, thank you for the patch.

Anyway this problem also affects external extensions - e.g. Phoca Guestbook which uses Joomla! core Category manager to store guestbooks, does not include/render "New" button:

http://www.phoca.cz/forum/viewtopic.php?f=2&t=27047

After applying the patch, everything is OK.

Jan

[epidote]

Just adding that my default clean install was working fine until I installed JCE, then I lost the buttons on articles. Switching back to tinyMCE didn't fix, but patch above worked.