joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

[j5.1][bug Dark theme] Styles error for a dark theme #43333

Open korenevskiy opened 7 months ago

korenevskiy commented 7 months ago

изображение According to the rules of the Bootstrap button design styles, the buttons can have a full color fill or OUTLINE.

So the Outline style doesn't work. We can see how the main color for a regular button differs from the color of the Outline button.

exlemor commented 7 months ago

Hi @korenevskiy, isn't this an issue with the extension developer and how the programmed that button vs a Joomla one?

(just asking/trying to understand for my own knowledge)

korenevskiy commented 7 months ago
<button  class=" btn btn-outline-primary btn-sm" type="button">Camera Start</button>

the truth is somewhere in between. Of course, this does not affect the Admin interface. But does the component developer have the right to use the style of the btn-outline-primary and btn-outline buttons? Since the template is based on Bootstrap. This means that the template should allow you to use a grid from Bootstrap, control styles, calendars and others.

brianteeman commented 7 months ago

Since the template is based on Bootstrap.

Based on bootstrap != is bootstrap

korenevskiy commented 7 months ago

You're right, but let's evaluate. Joomla should be treated as just a CMS without frameworks or a CMS with frameworks and libraries. So that you can rely on them

korenevskiy commented 7 months ago

And then it turns out that the programmer needs to connect the style to the admin panel.

korenevskiy commented 7 months ago

Maybe this is not a mistake of the dark theme of the template. But maybe this is the goal that Joomla adheres to in the long run.

coolcat-creations commented 1 month ago

Since Scanner QR Tickets is not a core module it seems the wrong classes have been used there and the issue might be closed? @Hackwar

korenevskiy commented 1 month ago

Since Scanner QR Tickets is not a core module it seems the wrong classes have been used there and the issue might be closed? @Hackwar

Let me remind you again. I'm thinking the problem here is not that Bootstrap dark theme is not supported. And the fact is that Joomla as a CMS should support Bootstrap so that developers can rely on it, or Joomla should not support bootstrap, and this is just a feature of the template. This is a matter of Joomla philosophy, not a bug in the code.

If our maintainers tell us that the Joomla tasks do not include Bootstrap support, then let's close the topic, or vice versa, put it in the task list.

coolcat-creations commented 1 month ago

@rdeutz please a decision :)

brianteeman commented 1 month ago

Core bootstrap - screenshot from their documentation

Image

Same code in a module in j5 admin

Image

While I accept that the colours may vary slightly the css in joomla is clearly not providing the expected styles. This is not the only place that core bootstrap markup does not work due to errors in the joomla css as we have the exact same problem in https://github.com/joomla/joomla-cms/issues/43708

korenevskiy commented 1 month ago

Don't get me wrong. It's not that I'm styling a dark theme and can't use a secondary button instead of a primary button. I can make another button. But the fact is that when the user uses a light theme, he should see the main button, I make it "Primary", but the user switches the theme to a dark one and the button becomes INVISIBLE. It turns out that I need to track the moment of switching themes so that the main button can change button classes. It turns out that to be sure of the color, only half of all the OUTLINE buttons can be used: Success, Danger, Warning, Info. I will use the button for these purposes. The Primary and Secondary buttons are not applicable by definition. Since they are either not visible, or they become brighter than the main button. Let's close this problem, here we need to make amendments to the built-in Bootstrap framework to correct the BTN-OUTLINE, or not distract attention. Let's vote.