search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.74k stars 3.64k forks source link

Unable to delete update server double #44204

Open cmirnow opened 23 hours ago

cmirnow commented 23 hours ago

In the dashboard of my Joomla site (5.1.4), after numerous updates (it's an old site) there are two identical update servers. I'm trying to delete one of them, but it's not working. Can you tell me what actions are available to me to remove this extra server? Is this a bug or a feature?

Image

Image

fgsw commented 20 hours ago

What i would do:

  1. Do a backup
  2. Open in my database the table *_update_sites in phpMyAdmin
  3. Delete the row

Having more questions ask in Forums and close this issue.

richard67 commented 19 hours ago

What i would do:

  1. Do a backup
  2. Open in my database the table *_update_sites in phpMyAdmin
  3. Delete the row

There is also a table update_sites_extensions which holds the cross references from update_sites to extensions. That should also be checked.

It is by design that you cannot delete a core update site, and the rebuild button also doesn’t touch core sites.

But maybe that should be changed/improved. I know of a few other cases where a site had a long update history and duplicate update sites for the core.

brianteeman commented 16 hours ago

But maybe that should be changed/improved. I know of a few other cases where a site had a long update history and duplicate update sites for the core.

For non protected update sites such as joomla core a rebuild of the update sites should resolve any duplicates

richard67 commented 16 hours ago

For non protected update sites such as joomla core a rebuild of the update sites should resolve any duplicates

@brianteeman Reading the code here looks to me as if this is not the case: https://github.com/joomla/joomla-cms/blob/5.2-dev/administrator/components/com_installer/src/Model/UpdatesitesModel.php#L304-L331

brianteeman commented 13 hours ago

Rebuild should delete all the update sites and then rebuild the table from the extension xml

richard67 commented 13 hours ago

Rebuild should delete all the update sites and then rebuild the table from the extension xml

@brianteeman I agree that it should do that, but it doesn't. Any update site which refers to the core (joomla files extension) will not be touched. I had once investigated a similar problem and tried it. Reading the code, especially the comment, made me then believe it is desired behaviour, so I haven't opened an issue.

cmirnow commented 12 hours ago

I agree that it should do that, but it doesn't.

@brianteeman , I opened this issue because the “rebuild” button does not solve the problem of removing the update server double. My opinion today is that this is a bug that needs to be fixed. But maybe the development community will decide otherwise.

brianteeman commented 8 hours ago

Rebuild should delete all the update sites and then rebuild the table from the extension xml

@brianteeman I agree that it should do that, but it doesn't. Any update site which refers to the core (joomla files extension) will not be touched.

Which is what I said

For non protected update sites such as joomla core a rebuild of the update sites should resolve any duplicates