joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

Pre-update check for extensions never stops (returning a json error) #44284

Closed obuisard closed 1 month ago

obuisard commented 1 month ago

Steps to reproduce the issue

I have tried to move a couple Joomla 5.1 sites to 5.2 under PHP 8.2. I waited for the pre-update checker to finish its job of checking extensions.

Expected result

Pre-update checks ends.

Actual result

They never do.

System information (as much as possible)

5.1 to 5.2 update PHP 8.2.19 MySQL 8.0.32

Additional comments

This is the error I get when looking at the data before the json info is parsed:

Image

<br />
<b>Deprecated</b>:  Creation of dynamic property Joomla\CMS\Updater\Update::$length is deprecated in <b>E:\bearsampp\www\MyWork_5_latest_free\libraries\src\Updater\Update.php</b> on line <b>486</b><br />
<br />
<b>Deprecated</b>:  Creation of dynamic property Joomla\CMS\Updater\Update::$length is deprecated in <b>E:\bearsampp\www\MyWork_5_latest_free\libraries\src\Updater\Update.php</b> on line <b>486</b><br />
{"success":true,"message":null,"messages":null,"data":{"compatibility": ...

Having the warning in the response forces the json parsing to fail.

exlemor commented 1 month ago

I had the same issue on one site - initially I tried doing so as a test from an iPhone 15 Pro (via Safari) and also then when I got home from a laptop running Safari 18 same result/issue as above

alikon commented 1 month ago

can you check adding declaration of $length in the Joomla\CMS\Updater\Update class , should solve

rdeutz commented 1 month ago

You can set the errror reporting to none, then you can continue with the update

alikon commented 1 month ago

44307 will remove the deprecation

richard67 commented 1 month ago

Closing as having a pull request. See #44307 .