URL in email broken with Mail Template Layout

leeroy1821 commented 3 weeks ago

Steps to reproduce the issue

Mail template com_users.password_reset

HTML Body:

<p>Hello,</p>
<p>
    A request has been made to reset your {SITENAME} account password. To reset your password, you will need to submit this verification code to verify that the request was legitimate.
</p>
<p>
    The verification code is {TOKEN}
</p>
<p>
    Click <a href="{LINK_HTML}">here</a> and proceed with resetting your password.    
</p>
<p>
    Thank you.
</p>

Expected result

URL in email is correct: https://www.mysite.com/component/users/reset.html?layout=confirm&token=blablabla&Itemid=123

Actual result

URL in email is broken: https://www.mysite.com/https://www.mysite.com/component/users/reset.html?layout=confirm&token=blablabla&Itemid=123

The https://www.mysite.com is dobled in email.

System information (as much as possible)

Joomla! 5.2.0
PHP 8.3.13

Additional comments

When I put Mail Template Layout to No, problem not exist. Make me think Mail Template Layout is problem.

I look in MailTemplate. Line 331 $htmlBody = MailHelper::convertRelativeToAbsoluteUrls($htmlBody);. Add var_dump($htmlBody); next to it. I see <a href="https://www.mysite.com/{LINK_HTML}">. But LINK_HTML already have https://www.mysite.com/! This comes the problem, no?

I move $htmlBody = MailHelper::convertRelativeToAbsoluteUrls($htmlBody); after the big if layout and problem not exist.

webmasterab commented 3 weeks ago

I also have this URL problem with the emails that are now sent by Joomla 5.2.

Very annoying. How nice that there is a solution soon. However, it is better to submit this as a pull request, then if it works and the test is successful, it can be adopted in the core.

Do you know how to create a pull request?

leeroy1821 commented 3 weeks ago

@webmasterab I can ask colleague. He helpt some month ago with pull request for passkeys. I will come with pull request in some hours.

leeroy1821 commented 3 weeks ago

I made pull request https://github.com/joomla/joomla-cms/pull/44378

Thanks!