joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

[5.2] Position search filter tooltip to bottom #44433

Open Quy opened 1 week ago

Quy commented 1 week ago

Pull Request for Issue #44086 .

Summary of Changes

Fix search filter tooltip being partially hidden.

Testing Instructions

Install pre-built package. Go to Administrator > Articles. Hover pointer over the Search filter box.

or

Use patch tester. Execute npm run build:css.

Actual result BEFORE applying this Pull Request

44086-tooltip

Expected result AFTER applying this Pull Request

44086-tooltip-pr

fgsw commented 1 week ago

I have tested this item :white_check_mark: successfully on 58586691e3da3aca61d12fb1e6f64a52714fc538

Using latest Firefox on Mac show tooltip over search filter, not at bottom, which is not important:

Untitled


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44433.

richard67 commented 1 week ago

@Quy It could be that system tests need some adjustment because they cannot reach the search field anymore. See screenshots in the artifacts https://artifacts.joomla.org/drone/joomla/joomla-cms/5.2-dev/44433/system-tests/80243/screenshots/administrator/components/ . I'm not sure if it is caused by this PR, but I think it could be.

brianteeman commented 1 week ago

Chrome windows - this places the tooltip so that it obscures the input. Thats not what we want as this prevents a user from entering anything in the input

brianteeman commented 1 week ago

I have tested this item :red_circle: unsuccessfully on 58586691e3da3aca61d12fb1e6f64a52714fc538


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44433.

brianteeman commented 1 week ago

Using latest Firefox on Mac show tooltip over search filter, not at bottom, which is not important:

On chrome for windows it is very important as it prevents you entering anything into the input

fgsw commented 1 week ago

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44433.