search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.78k stars 3.65k forks source link

[5.3] Test Upmerge #44440

Closed heelc29 closed 1 week ago

heelc29 commented 2 weeks ago

test drone

LadySolveig commented 1 week ago

Thank you so much for your work on this topic @heelc29 !

Could you please open a new PR for 5.3 with the changes from your last two commits. We should not ‘hide’ direct changes in the library, nor the enhancement of the test in an upmerge.

We will make the upmerge with these change https://github.com/joomla/joomla-cms/pull/44434/commits/4f2a09ef42676f91647ebecdef27bf1e73117e17 for the time being to prevent the test from breaking. But I would be very happy about a new PR from you with these changes to make it transparent for everyone in the project.

heelc29 commented 1 week ago

We should not ‘hide’ direct changes in the library, nor the enhancement of the test in an upmerge.

That wasn't my intention either, so this is in draft state.

My target is to split this into 2-3 PRs:

HLeithner commented 1 week ago

closing in favor of #44463