joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.78k stars 3.65k forks source link

[5.3] Update deleted files in script.php for the upcoming 5.3.0-alpha1 #44450

Closed richard67 closed 1 week ago

richard67 commented 1 week ago

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in script.php to the latest changes in the 5.3-dev branch.

Currently there are only files from PR #44296 .

Testing Instructions

Code review and check the description of PR #44296 , or compare a recent 5.3-dev nightly build with a 5.2-dev nightly build and check for files which exist only in the 5.2-dev but not in 5.3-dev build.

Actual result BEFORE applying this Pull Request

The files added by this PR to the list are still there after an update from 5.2.x to 5.3-dev.

Expected result AFTER applying this Pull Request

The files added by this PR to the list are deleted after an update from 5.2.x to 5.3-dev.

Link to documentations

Please select:

richard67 commented 1 week ago

@dgrammatiko As you have removed the build/media_source/system/scss/joomla-core-loader.scss from the sources with your PR #44296 : Can we safely delete the files on update? Or should we keep them for b/c reasons in case if a 3rd party extensions still uses them or refers to them?

dgrammatiko commented 1 week ago

It's safe to remove those files as they where used exclusively during the bundling, they won't affect the web component as it already has those encapsulated (either before or after the PR #44296). In sort, this is good, thanks

richard67 commented 1 week ago

@dgrammatiko Thanks for the quick reply.

bembelimen commented 1 week ago

Thx