search

joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

[5.3] Upmerge 2024-11-14 #44456

Closed LadySolveig closed 5 days ago

LadySolveig commented 1 week ago

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

richard67 commented 1 week ago

@LadySolveig System tests are failing for the contact router single contact without menu item test. It seems it needs to revert my fix from here https://github.com/joomla/joomla-cms/pull/44434/commits/4f2a09ef42676f91647ebecdef27bf1e73117e17 .

Hmm, or it needs the same change for the new code which was added below that line.

heelc29 commented 1 week ago

It needs this commit https://github.com/joomla/joomla-cms/commit/aab9ce1d1631d202e1483cb219bf8aa8ed74f09a I can create later a PR for it.

heelc29 commented 1 week ago

I can create later a PR for it.

check out #44459

HLeithner commented 5 days ago

closing in favor of #44463