joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.78k stars 3.65k forks source link

[5.3]Sort order of fields relative to their actual location in the table #44486

Open brianteeman opened 6 days ago

brianteeman commented 6 days ago

Pull Request for Issue #34501 .

Summary of Changes

in the element sorting field on the page, the STAGE field is at the very bottom, however, I remember exactly that we previously saved the order in this field relative to the actual location in the table (in this case, the stage line should be the second after ORDERING).

This pull request includes changes to the workflow-related sorting options in the content management system. The changes ensure that these options are only available when the workflow feature is enabled AND that they are positioned in the filter in the correct position

Workflow-related sorting options:

Conditional form field handling:

Conditional option inclusion:

Testing Instructions

Using Sample Data Test 1. Enable workflows and observe in the sort filter dropdown the position of Stage Asc/Desc in the list Test 2. Disable Workflows and observe that Stage Asc/Desc is not present in the list

Actual result BEFORE applying this Pull Request

  1. At the bottom of the list
  2. Not present

Expected result AFTER applying this Pull Request

  1. Near the top Directly below ordering to match the column order in the table
  2. Not present

Link to documentations

Please select:

Kostelano commented 6 days ago

I have tested this item :white_check_mark: successfully on d44ec3ce7d5a87b21eec94d2428275e7b057ba45

The fix works


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

Quy commented 5 days ago

I have tested this item :white_check_mark: successfully on d44ec3ce7d5a87b21eec94d2428275e7b057ba45


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

Quy commented 5 days ago

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

brianteeman commented 5 days ago

@quy @Kostelano I forgot to do the same for the featured articles list - please can you additionally test that

Quy commented 5 days ago

I have tested this item :white_check_mark: successfully on d223bd3b934230db6f574c147bf76ce51a0e0071


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.

Kostelano commented 5 days ago

I have tested this item :white_check_mark: successfully on d223bd3b934230db6f574c147bf76ce51a0e0071


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44486.