[5.2] Email alt text on contact

brianteeman commented 2 days ago

Pull Request for Issue #37442 .

Summary of Changes

The wrong language string was being referenced. This had previously been fixed when using icons but was missed when using images

Comments about using alt titles and possibly invalid DT elements when using images instead of icons is beyond the scope of this PR. That is a bigger issue for the a11y team to consider

Testing Instructions

Go to Global Configuration -> Component -> Contacts -> Icon panel
Set Settings drop-down list to Icons
Select any picture for Custom Email Icon
Create a contact, add every contact datas (name, address, email, etc.)
Display the created contact using any kind of template (preferable Cassiopeia) which doesn't use template override for the file "components/com_contact/tmpl/contact/default_address.php"
Check the alt text of the selected image of email

Actual result BEFORE applying this Pull Request

The image used for the address image has a non translated value of alt="COM_CONTACT_EMAIL"

Expected result AFTER applying this Pull Request

All the images have an ALT text description

Link to documentations

Please select:

[ ] Documentation link for docs.joomla.org:
[x] No documentation changes for docs.joomla.org needed
[ ] Pull Request link for manual.joomla.org:
[x] No documentation changes for manual.joomla.org needed

fgsw commented 2 days ago

I have tested this item :white_check_mark: successfully on 0549e4b84cdb08b603507515073623305dc0b1f1

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44491.}

chmst commented 2 days ago

I am not in favour of this solution. The alt text now repeats the name of the contact. This is no help or information

grafik

It wold be better to use an empty alt-text or to use our usual solution where the user can decide if the image is only decorative or add useful information for example "smiling lady with greay hair" or "access to my office has two steps" instead of repeating the contacts name.

brianteeman commented 1 day ago

@chmst I agree with you - but that is a different issue which needs to be addressed for all the images - this PR is ONLY for the missing text on the email image.

The alt text on the contact image is nothing to do wioth this PR and there is a seperate issue/pull request elsewhere for that.

Comments about using alt titles and possibly invalid DT elements when using images instead of icons is beyond the scope of this PR. That is a bigger issue for the a11y team to consider

Please please dont make the mistake I made before and prevent this fix because you are looking at a completely different issue.

chmst commented 1 day ago

@brianteeman I know the complexity, this is why I did not touch this issue ;) The contact component needs a lot of work. I think that alt="" would be better, but I will not block your solution.

brianteeman commented 1 day ago

PLEASE - look at this PR and what it does. It fixes a simple bug. It does nothing more but thanks to your completely off topic and irrelevant post talking about something com0pletely different its no wonder its been left for so long. Wish I hadnt bothered.

fgsw commented 1 day ago

@brianteeman can you please reopen the Pull Request?

joomla / joomla-cms