joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

[5.3] add composer scripts for cs check and add excludes to php-cs-fixer config #44498

Open LadySolveig opened 1 day ago

LadySolveig commented 1 day ago

Pull Request for Issue # .

Summary of Changes

Add commands

Add excludes for cacheand logsdirectory to php-cs-fixer configuration as we have the same exlcudes for phpcs. Improvement for our nice contributors.

Testing Instructions

Open a terminal (and step into the cloned joomla developement folder)

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

brianteeman commented 19 hours ago

is it expected to get this error at the end of running phpcs?

image

and this error at the end of running csfixer

image

LadySolveig commented 4 hours ago

No, absolutely not an expected result. I have tried to replicate your issue but unfortunately I can't recreate it at the moment.

I have seen you run it directly on Windows. Since I usually use Linux, I have now installed php 8.3 and composer directly on Windows.

But for me it runs without errors here too.

composer run phpcs Screenshot 2024-11-22 084946 Screenshot 2024-11-22 084428

composer run csfixer Screenshot 2024-11-22 084803

Is your IDE or your Git client possibly doing something with the line endings?