joomla / joomla-cms

Home of the Joomla! Content Management System
https://www.joomla.org
GNU General Public License v2.0
4.77k stars 3.65k forks source link

[5.3] Add the js-grid-item-is-checked class and remove onClick HtmlHelper Grid #44501

Open LadySolveig opened 1 day ago

LadySolveig commented 1 day ago

Pull Request for Issue # .

Summary of Changes

This PR adds the js-grid-item-is-checked class and remove onClick in the HtmlHelper for Grid as it was originally prepared in the script. https://github.com/joomla/joomla-cms/blob/04d427694b46e9ba9506057723896e1e9aabb9b9/build/media_source/system/js/list-view.es6.js#L99

Testing Instructions

Install this PR Do the same again.

Actual result BEFORE applying this Pull Request

All should work.

Expected result AFTER applying this Pull Request

All should work as before.

Link to documentations

Please select:

Quy commented 18 hours ago

I have tested this item :white_check_mark: successfully on 5b16e75b7b0a4c465cc0fdac5bade98dfc5928d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44501.

dgrammatiko commented 7 hours ago

FWIW I had to revert this some time ago as it broke 3rd PD code: https://github.com/joomla/joomla-cms/pull/40192 But would be cool to have CSP strict OOTB at some point