joomla / joomla-framework

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla-framework for the individual Framework packages.
http://framework.joomla.org
GNU General Public License v2.0
189 stars 140 forks source link

Improvements to Application docs #320

Closed piotr-cz closed 10 years ago

piotr-cz commented 10 years ago

Described some things that are not obvious from the docblocks.

I'm confused, what is supposed to come into README.md's. Now we have

dongilbert commented 10 years ago

Could you also update line 97 to say Monolog instead of Logger. The Logger class doesn't exist in the context of that example. After that, I think it's good to merge.

piotr-cz commented 10 years ago

@dongilbert Actually I think that the Monolog class doesn't exist, see Monolog > Logger.php so it's the use statement at line 78 that needs an update:

use Monolog\Logger;
dongilbert commented 10 years ago

Good catch, I was just going off memory and what I saw. Thanks @piotr-cz.