joomla / joomla-framework

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla-framework for the individual Framework packages.
http://framework.joomla.org
GNU General Public License v2.0
189 stars 140 forks source link

Enables Memcached Session and Cache testing on Travis. #331

Closed ghost closed 10 years ago

ghost commented 10 years ago

Integrates changes into a single documented commit in place of https://github.com/joomla/joomla-framework/pull/330

Corrects bugs in construction of Memcached Session and Cache objects which can cause failures if the default configuration is not in use.

Implements Unit Tests of most class methods to ensure that they really are working.

Refactors Unit Tests for Joomla\Cache\Cache to remove calls to methods that are specific to a hard coded class name and replace it with something that subclasses can set via setUp - reduce copy and paste of test code and instead Cache engine tests should inherit from CacheTest

Refactor for Joomla\Session\Storage to do the same in theory. In practice, because it is an Abstract class the calling mechanisms are not compatible. Instead of requiring every storage engine to re-implement each and every test, testing methodology was embedded into the new StorageCase interface which every Storage Test Class should implement. Logic should be usable for any class except for StorageTest, which both implements and overrides almost every method.

dongilbert commented 10 years ago

Thanks @garyamort!