joomla / joomla-framework

[READ-ONLY] This repo is no longer in active development. Please see https://github.com/joomla-framework for the individual Framework packages.
http://framework.joomla.org
GNU General Public License v2.0
189 stars 140 forks source link

Get tests running in the respective packages, independently #4

Closed eddieajau closed 10 years ago

eddieajau commented 11 years ago

See the Date package for a good example.

Complete:

eddieajau commented 11 years ago

Database done. I've put in a new Joomla/Test package. It was just getting a bit crazy to fit up TestReflection and also the mock builders. I'm assuming we can only include that if "dev" is set. Anyway, see what you think. ONly took 6 hours straight to patch it all up.

eddieajau commented 11 years ago

Utilities and Registry done.

eddieajau commented 11 years ago

Data package done.

eddieajau commented 11 years ago

String package done.

dongilbert commented 11 years ago

Working on Controller

dongilbert commented 11 years ago

ehh - maybe scratch that. Not sure what to do about it's dependency on JFactory. :(

So, until we refactor the code, it's kind of not possible to make these tests separate.

(and I thought I was picking an easy one)

mbabker commented 11 years ago

Attempting Model (maybe I got the easy one :wink: )

mbabker commented 11 years ago

Working Application

mbabker commented 11 years ago

Http's done. I actually finished one... LOL

eddieajau commented 11 years ago

Whoot! Another one bits the dust.

mbabker commented 11 years ago

Uri done.

dongilbert commented 11 years ago

I'll be working on the following packages tonight:

Google Image

mbabker commented 11 years ago

Where do we stand with this one?

dongilbert commented 11 years ago

We'll see after we tag beta3 and try to run composer install; phpunit in each directory. :)

dongilbert commented 11 years ago

IIRC, the only remaining conflicts were due to the inability of composer to resolve dependencies.

wilsonge commented 11 years ago

So much phpcs to be fixed tho :P

dongilbert commented 11 years ago

Jump on it bro.

mbabker commented 11 years ago

Perfect low hanging fruit for a student wanting to get their feet wet in the PHP world :-P

On Tue, Oct 22, 2013 at 5:08 PM, George Wilson notifications@github.comwrote:

So much phpcs to be fixed tho :P

— Reply to this email directly or view it on GitHubhttps://github.com/joomla/joomla-framework/issues/4#issuecomment-26858061 .

dongilbert commented 11 years ago

Exactly @mbabker. It's not that I don't want to do it (I do, in fact, want to), but it's a great opportunity for those who want to to build some cred and experience. Fixing CS is how I got to most LOC touched on the FW.

wilsonge commented 11 years ago

haha. If I have time I'll get on it. Still getting screwed by my essay at the moment that's due on Friday + a couple of job applications I need to rewrite my CV for due next week. And my need to learn a load of electronics I claimed I already knew about for my final year project so I got a good project haha.

Although just saying I was at a careers fair today - where I was scoffed for learning PHP because Java is the language of professionals apparently :P

On 22 October 2013 23:14, Don Gilbert notifications@github.com wrote:

Exactly @mbabker https://github.com/mbabker. It's not that I don't want to do it (I do, in fact, want to), but it's a great opportunity for those who want to to build some cred and experience. Fixing CS is how I got to most LOC touched on the FW.

— Reply to this email directly or view it on GitHubhttps://github.com/joomla/joomla-framework/issues/4#issuecomment-26859241 .

eddieajau commented 10 years ago

I'm going to close this one and if there are any problems we can fix problems individually.